コメントを追加

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/16 19:41 まどか

私は、
Protected Sub OnEvent1(ByVal e As EventArgs)
RaiseEvent Event1(Me, EventArgs.Empty)
End Sub
Protected Sub OnEvent2(ByVal e As EventArgs)
RaiseEvent Event2(Me, EventArgs.Empty)
End Sub
２つのEventArgs.Emptyは意味として違うものととらえています。

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/17 0:20 dai-okuno

はじめまして。

イベントハンドラの使いまわしは、メソッドの凝集度を低下させるのでは？
保守性が悪くなるので、するべきではないと思います。
私なら、下のようなコードを書きます。

Private Sub FrmMain_KeyUp(sender, e)
　Select Case e.KeyCode
　　Case Keys.NumPad1, Keys.D1
　　　ProcessCost()
　End Select
End Sub

Private Sub Button1_Click(sender, e)
　ProcessCost()
End Sub

Private Sub ProcessCost()
　' サブフォームの生成が重いなら、フィールドにキャッシュ。
　Using(subForm = new FrmCostProcess())
　　subForm.ShowDialog(Me)
　End Using
End Function

これなら、機能的凝集度と言えるかと。

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/17 1:40 稍丼

別メソッドに切り出すのって，
一見，納得するし，そういう解説もよく見るけど，
そうすると，結局，
ハンドラメソッドにビジネスロジックを
最初から書いてはいけないことになってしまいますよね。

Button1_Click という名前だから，
なんとなく変に感じるだけで，
変に感じるのなら，最初から
HogeHoge(sender As Object, e As EventArgs)
というシグナチャのメソッドを登録すればいいわけで，
ひとつのイベントに，ひとつのハンドラメソッドが
一対一で対応しないと気が済まないのは，
VB6 のなごりのような気もするんですけどね。

そのなごりのままだと，WPFのよさが半減するかも。

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/17 1:57 稍丼

と理屈的には思うけど，
でも，やっぱり自分も別メソッドに分けてしまうかな。

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/17 3:19 稍丼

実は，
VB6 と違って sender があるということは，
e の出所をちゃんと確認してからやるには，

Sub Button1_Click(sender As Object, e As EventArgs)
Dim btn As Button = TryCast(sender, Button)
If btn IsNot Nothing Then
'ここで初めて e が Buttonのイベントと
'結びついていることがわかる。
End If
End Sub

としておかないといけないんですよね。
ふつうはそんなことしないですけど。

で，
WPF の話と絡んで出ているのは，
WPFだとこれが必須になるので，
一対一に慣れてしまっていると面倒だと感じるだろうし，
実際，面倒ですし，納得もいかないだろうという話です。

例えば，Click というイベントならば，
ButtonがClickではなく，
仕組み的には，MouseがClickだからです。

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/17 11:07 通りすがり

中さんに同意

何故引数の雛形がobject senderになっているのか意味がなくなると思います。
その考え方なら雛形がbutton senderとかが正になりません？

WPFに触れられると考え方が変わるかもしれません。

# re: 同じ引数なのに再利用しちゃいけない理由なんてある？ 2007/12/18 1:46 dai-okuno

WPFに限らず、１つのメソッドを複数のイベントの
ハンドラとして使用することそのものが問題とは思いません。
しかし、このケースでは余分な複雑性が生じているのでは？

・FrmMain_KeyUpから実行すべき処理が不明。
　Button1_Clickの定義を確認しなくてはならない。

・Button1_Clickの名前から外れた使用法である。
　Button1_Clickに変更が入った場合、FrmMain_KeyUpからの
　呼び出しでは不適切な変更を行う可能性が高くなる。

・目的の処理を行うのに、senderもeも不要。
　メソッドの引数は必要最低限にするべき。

逆に、FrmMain_KeyUpからButton1_Clickへ委譲する
積極的な理由は何なのでしょう？

# May I simply just say what a comfort to find somebody who actually understands what they're discussing online. You actually understand how to bring an issue to light and make it important. A lot more people need to read this and understand this side of 2018/02/17 13:43 May I simply just say what a comfort to find someb

May I simply just say what a comfort to find somebody who actually understands what they're discussing online.
You actually understand how to bring an issue to light and make it important.
A lot more people need to read this and understand this side of your story.
I was surprised that you're not more popular since you most certainly have the gift.

# Terrific work! This is the kind of information that should be shared across the web. Shame on the search engines for now not positioning this post upper! Come on over and discuss with my website . Thanks =) 2018/05/28 5:49 Terrific work! This is the kind of information tha

Terrific work! This is the kind of information that
should be shared across the web. Shame on the search
engines for now not positioning this post upper!
Come on over and discuss with my website . Thanks =)

# Tһis pocket knife was called Modeⅼl 1890. 2019/03/18 20:38 This pocкet knife ѡwas called Modell 1890.

Thi? pocket knife was c?llеd Modell 1890.

# If you desire to take much from this article then you have to apply such methods to your won website. 2019/06/30 20:21 If you desire to take much from this article then

If you desire to take much from this article then you have to apply such methods to your won website.

# Incredible story there. What happened after? Good luck! 2019/07/08 6:09 Incredible story there. What happened after? Good

Incredible story there. What happened after? Good luck!

# Spot on with this write-up, I really believe that this amazing site needs a great deal more attention. I'll probably be returning to read through more, thanks for the advice! 2019/07/14 6:17 Spot on with this write-up, I really believe that

Spot on with this write-up, I really believe that this amazing site needs
a great deal more attention. I'll probably be returning to read
through more, thanks for the advice!

# Just a smiling visitant here to share the love (:, btw outstanding pattern. 2019/07/17 22:28 Just a smiling visitant here to share the love (:,

Just a smiling visitant here to share the love (:
, btw outstanding pattern.

# Just a smiling visitant here to share the love (:, btw outstanding pattern. 2019/07/17 22:30 Just a smiling visitant here to share the love (:,

Just a smiling visitant here to share the love (:
, btw outstanding pattern.

# Just a smiling visitant here to share the love (:, btw outstanding pattern. 2019/07/17 22:32 Just a smiling visitant here to share the love (:,

Just a smiling visitant here to share the love (:
, btw outstanding pattern.

# Just a smiling visitant here to share the love (:, btw outstanding pattern. 2019/07/17 22:34 Just a smiling visitant here to share the love (:,

Just a smiling visitant here to share the love (:
, btw outstanding pattern.

# I have learn some excellent stuff here. Definitely worth bookmarking for revisiting. I wonder how a lot effort you place to make this kind of excellent informative site. 2019/07/23 9:08 I have learn some excellent stuff here. Definitely

I have learn some excellent stuff here. Definitely worth bookmarking for revisiting.
I wonder how a lot effort you place to make this kind of excellent informative site.

# I have learn some excellent stuff here. Definitely worth bookmarking for revisiting. I wonder how a lot effort you place to make this kind of excellent informative site. 2019/07/23 9:10 I have learn some excellent stuff here. Definitely

I have learn some excellent stuff here. Definitely worth bookmarking for revisiting.
I wonder how a lot effort you place to make this kind of excellent informative site.

# I have learn some excellent stuff here. Definitely worth bookmarking for revisiting. I wonder how a lot effort you place to make this kind of excellent informative site. 2019/07/23 9:12 I have learn some excellent stuff here. Definitely

I have learn some excellent stuff here. Definitely worth bookmarking for revisiting.
I wonder how a lot effort you place to make this kind of excellent informative site.

# I have learn some excellent stuff here. Definitely worth bookmarking for revisiting. I wonder how a lot effort you place to make this kind of excellent informative site. 2019/07/23 9:14 I have learn some excellent stuff here. Definitely

I have learn some excellent stuff here. Definitely worth bookmarking for revisiting.
I wonder how a lot effort you place to make this kind of excellent informative site.

# You made some good points there. I checked on the internet to find out more about the issue and found most people will go along with your views on this website. 2019/07/24 12:36 You made some good points there. I checked on the

You made some good points there. I checked on the internet to find out more
about the issue and found most people will go along with your views on this website.

# You made some good points there. I checked on the internet to find out more about the issue and found most people will go along with your views on this website. 2019/07/24 12:38 You made some good points there. I checked on the

You made some good points there. I checked on the internet to find out more
about the issue and found most people will go along with your views on this website.

# You made some good points there. I checked on the internet to find out more about the issue and found most people will go along with your views on this website. 2019/07/24 12:40 You made some good points there. I checked on the

You made some good points there. I checked on the internet to find out more
about the issue and found most people will go along with your views on this website.

# You made some good points there. I checked on the internet to find out more about the issue and found most people will go along with your views on this website. 2019/07/24 12:42 You made some good points there. I checked on the

You made some good points there. I checked on the internet to find out more
about the issue and found most people will go along with your views on this website.

# Good - I should certainly pronounce, impressed with your website. I had no trouble navigating through all the tabs as well as related info ended up being truly easy to do to access. I recently found what I hoped for before you know it in the least. Rea 2019/08/29 13:05 Good - I should certainly pronounce, impressed wit

Good - I should certainly pronounce, impressed with your website.
I had no trouble navigating through all the tabs as
well as related info ended up being truly easy to do
to access. I recently found what I hoped for before you know it in the least.
Reasonably unusual. Is likely to appreciate it for those who add forums or something, website theme
. a tones way for your customer to communicate.
Excellent task.

# I loved as much as you'll receive carried out right here. The sketch is attractive, your authored subject matter stylish. nonetheless, you command get got an nervousness over that you wish be delivering the following. unwell unquestionably come more fo 2019/08/31 23:12 I loved as much as you'll receive carried out righ

I loved as much as you'll receive carried out right here.
The sketch is attractive, your authored subject matter stylish.

nonetheless, you command get got an nervousness over that you wish be delivering the following.

unwell unquestionably come more formerly again as exactly the same
nearly very often inside case you shield this hike.

# Just want to say your article is as astounding. The clearness to your publish is just cool and that i can assume you're knowledgeable in this subject. Fine along with your permission let me to grasp your RSS feed to keep updated with impending post. Tha 2021/07/09 23:30 Just want to say your article is as astounding. Th

Just want to say your article is as astounding.
The clearness to your publish is just cool and that i can assume you're knowledgeable in this
subject. Fine along with your permission let me to grasp your RSS feed to keep updated with impending post.
Thanks one million and please carry on the rewarding work.

# I think this is one of the most important info for me. And i'm glad reading your article. But want to remark on few general things, The website style is perfect, the articles is really excellent : D. Good job, cheers 2021/09/16 5:50 I think this is one of the most important info fo

I think this is one of the most important info for me.
And i'm glad reading your article. But want to remark on few general things, The website style is perfect,
the articles is really excellent : D. Good job, cheers

# I visited several sites but the audio quality for audio songs present at this web page is genuinely wonderful. 2021/09/23 3:52 I visited several sites but the audio quality for

I visited several sites but the audio quality for audio songs present at this web page is genuinely wonderful.

# Pretty! This has been an extremely wonderful post. Thanks for providing these details. 2021/09/23 10:10 Pretty! This has been an extremely wonderful post.

Pretty! This has been an extremely wonderful post. Thanks for providing these details.

# Pretty! This has been an extremely wonderful post. Thanks for providing these details. 2021/09/23 10:12 Pretty! This has been an extremely wonderful post.

Pretty! This has been an extremely wonderful post. Thanks for providing these details.

# Pretty! This has been an extremely wonderful post. Thanks for providing these details. 2021/09/23 10:15 Pretty! This has been an extremely wonderful post.

Pretty! This has been an extremely wonderful post. Thanks for providing these details.

# Pretty! This has been an extremely wonderful post. Thanks for providing these details. 2021/09/23 10:18 Pretty! This has been an extremely wonderful post.

Pretty! This has been an extremely wonderful post. Thanks for providing these details.

# of course like your website but you need to take a look at the spelling on several of your posts. Many of them are rife with spelling issues and I to find it very bothersome to inform the truth however I will surely come back again. 2021/09/23 12:18 of course like your website but you need to take a

of course like your website but you need to take a look at
the spelling on several of your posts. Many of them are rife with spelling issues and I to
find it very bothersome to inform the truth however I will surely come
back again.

# Its like you read my mind! You appear to know a lot about this, like you wrote the book in it or something. I think that you can do with a few pics to drive the message home a little bit, but instead of that, this is excellent blog. A great read. I will 2021/09/24 19:05 Its like you read my mind! You appear to know a lo

Its like you read my mind! You appear to know a
lot about this, like you wrote the book in it or something.
I think that you can do with a few pics to drive the
message home a little bit, but instead of that, this is excellent blog.
A great read. I will definitely be back.

# Its like you read my mind! You appear to know a lot about this, like you wrote the book in it or something. I think that you can do with a few pics to drive the message home a little bit, but instead of that, this is excellent blog. A great read. I will 2021/09/24 19:05 Its like you read my mind! You appear to know a lo

Its like you read my mind! You appear to know a
lot about this, like you wrote the book in it or something.
I think that you can do with a few pics to drive the
message home a little bit, but instead of that, this is excellent blog.
A great read. I will definitely be back.

# Its like you read my mind! You appear to know a lot about this, like you wrote the book in it or something. I think that you can do with a few pics to drive the message home a little bit, but instead of that, this is excellent blog. A great read. I will 2021/09/24 19:05 Its like you read my mind! You appear to know a lo

Its like you read my mind! You appear to know a
lot about this, like you wrote the book in it or something.
I think that you can do with a few pics to drive the
message home a little bit, but instead of that, this is excellent blog.
A great read. I will definitely be back.

# Its like you read my mind! You appear to know a lot about this, like you wrote the book in it or something. I think that you can do with a few pics to drive the message home a little bit, but instead of that, this is excellent blog. A great read. I will 2021/09/24 19:05 Its like you read my mind! You appear to know a lo

Its like you read my mind! You appear to know a
lot about this, like you wrote the book in it or something.
I think that you can do with a few pics to drive the
message home a little bit, but instead of that, this is excellent blog.
A great read. I will definitely be back.

# They have networks over the globe and can connect youu to a few of the mst effective resellers off social media providers. 2021/12/29 2:23 They have networks over tthe globe and can connect

They have networks over tthe globe and can conneft you to a ffew
of the most effective resellers of social meedia providers.

# Hello there! This article could not be written much better! Reading through this article reminds me of my previous roommate! He continually kept preaching about this. I am going to forward this information to him. Fairly certain he will have a very good 2022/05/01 2:29 Hello there! This article could not be written muc

Hello there! This article could not be written much better!
Reading through this article reminds me of my previous roommate!
He continually kept preaching about this.
I am going to forward this information to him. Fairly certain he will have a very
good read. I appreciate you for sharing!

# Hello there! This article could not be written much better! Reading through this article reminds me of my previous roommate! He continually kept preaching about this. I am going to forward this information to him. Fairly certain he will have a very good 2022/05/01 2:30 Hello there! This article could not be written muc

Hello there! This article could not be written much better!
Reading through this article reminds me of my previous roommate!
He continually kept preaching about this.
I am going to forward this information to him. Fairly certain he will have a very
good read. I appreciate you for sharing!

# Hello there! This article could not be written much better! Reading through this article reminds me of my previous roommate! He continually kept preaching about this. I am going to forward this information to him. Fairly certain he will have a very good 2022/05/01 2:30 Hello there! This article could not be written muc

Hello there! This article could not be written much better!
Reading through this article reminds me of my previous roommate!
He continually kept preaching about this.
I am going to forward this information to him. Fairly certain he will have a very
good read. I appreciate you for sharing!

# Hello there! This article could not be written much better! Reading through this article reminds me of my previous roommate! He continually kept preaching about this. I am going to forward this information to him. Fairly certain he will have a very good 2022/05/01 2:30 Hello there! This article could not be written muc

Hello there! This article could not be written much better!
Reading through this article reminds me of my previous roommate!
He continually kept preaching about this.
I am going to forward this information to him. Fairly certain he will have a very
good read. I appreciate you for sharing!

# I do not even know how I stopped up here, but I thought this publish was great. I don't realize who you're however definitely you are going to a well-known blogger in case you aren't already. Cheers! 2024/02/01 15:56 I do not even know how I stopped up here, but I th

I do not even know how I stopped up here, but I thought this
publish was great. I don't realize who you're however definitely you are
going to a well-known blogger in case you aren't already.
Cheers!

# I do not even know how I stopped up here, but I thought this publish was great. I don't realize who you're however definitely you are going to a well-known blogger in case you aren't already. Cheers! 2024/02/01 15:57 I do not even know how I stopped up here, but I th

I do not even know how I stopped up here, but I thought this
publish was great. I don't realize who you're however definitely you are
going to a well-known blogger in case you aren't already.
Cheers!

タイトル		タイトルを入力してください
名前		名前を入力してください
URL
コメント   コメントを入力してください
名前をブラウザに記憶する